-
Notifications
You must be signed in to change notification settings - Fork 16
all test now will pass #10
base: main
Are you sure you want to change the base?
Conversation
Hey @hasundue I did , If you need a talk let me know |
Thank you for submission! An interesting solution. Note that we ask you "without modifying or removing any existing lines in the original code." in the problem statement. |
Yes I noticed , but the reason that made me reach this solution was 'cause I was following what was stated on test(code) ,I mean the since e2e test , which was starting from running up dev server and then after it get up click on image which would redirect to main website (www.active-connector.com/) because that image has a link to do that , and then click on the input that was in the main website and so fourth, I tried test every step agaist the main website which I've notice on assertion was waiting for way different value from the main website , also page.location was being changing to the local one that had nothing that previous stated on assertion , no ui component's reponse that assertion was expecting . In order to avoid make to much attempt I did it in my repo , I've done about 65 worflow test |
|
Sorry but I'm feeling bad these days. But, if you make whatever changes you like on the code, what is the sense of this test? |
No probs I understand , I make the neccessary changes without even change the orignal code , so I found two solution for this , I did check all test and did tried make pass for about 65 times that made me realize to much about this , so I'll do the necessary change and I'll update it , is it ok to you ? |
for now you can just skip this review , I'll send another pull request , I'll make the necessary changes on my repo you can check if you want after I get done I'll open new pull request again , is it ok to you? |
Thank you! |
Questionnaire
Agreement