Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change example node version manager to match description of .node-version #968

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

shadowspawn
Copy link
Contributor

nvm does not support reading the .node-version file, and without manually adding scripts or other packages does not support changing node version when change directory.

fnm does read the .node-version file, runs on Windows too, and supports --use-on-cd so is a good match for the described benefits.


For interest, I saw the .node-version mention in the README of actions created using this template. I keep an eye out for uses of .node-version and will add this repo:

https://github.com/shadowspawn/node-version-usage

@shadowspawn shadowspawn requested a review from a team as a code owner November 12, 2024 08:48
Copy link
Collaborator

@ncalteen ncalteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! Good callout regarding nvm :)

@ncalteen ncalteen merged commit 7c73dd1 into actions:main Nov 12, 2024
6 checks passed
@ncalteen ncalteen self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants