Integrate cache service v2 #1857
Open
+4,864
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robherley
reviewed
Oct 24, 2024
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Liabaemt
approved these changes
Nov 1, 2024
joshmgross
reviewed
Nov 14, 2024
packages/cache/src/cache.ts
Outdated
| * @param enableCrossOsArchive an optional boolean enabled to restore on windows any cache created on any platform | ||
| * @returns string returns the key for the cache hit, otherwise returns undefined | ||
| */ | ||
| async function restoreCachev2( |
There was a problem hiding this comment.
Is there an opportunity to share code between restoreCachev1 and restoreCachev2 instead of duplicating it all?
That would make it easier to see what's actually changing and improve long-term maintenance of supporting both paths (such as for GHES).
Comment on lines
+245
to
+246
| workflowRunBackendId: backendIds.workflowRunBackendId, | ||
| workflowJobRunBackendId: backendIds.workflowJobRunBackendId, |
There was a problem hiding this comment.
Do we really need these in the request if they're encoded into the JWT?
Link-
commented
Nov 14, 2024
| @@ -45,10 +45,13 @@ | |||
| "@azure/abort-controller": "^1.1.0", | |||
| "@azure/ms-rest-js": "^2.6.0", | |||
| "@azure/storage-blob": "^12.13.0", | |||
| "semver": "^6.3.1" | |||
| "@protobuf-ts/plugin": "^2.9.4", | |||
There was a problem hiding this comment.
These have been moved from the top level package.json. And @protobuf-ts/plugin was bumped up to 2.9.4. Not sure why were using (and still using) @protobuf-ts/plugin": "^2.2.3-alpha.1 in artifacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the cache package to integrate with the new cache service backend (cache service v2). Major changes to the API layer are involved with this change but the interfaces are backward compatible. The transition to the new service will undergo gradual rollout and will be seamless to end users.
More context
Deprecation notice for v1 and v2 of actions/cache