Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent "too many open files" in artifact upload #1771

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Prevent "too many open files" in artifact upload #1771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9517cdf
Prevent "too many open files" in artifact upload
rmunn Jul 23, 2024
7c61054
Remove unused import
rmunn Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/artifact/src/internal/upload/zip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as stream from 'stream'
import * as archiver from 'archiver'
import * as core from '@actions/core'
import {createReadStream} from 'fs'

Check failure on line 4 in packages/artifact/src/internal/upload/zip.ts

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest) 

'createReadStream' is defined but never used

Check failure on line 4 in packages/artifact/src/internal/upload/zip.ts

View workflow job for this annotation

GitHub Actions / Build (macos-latest) 

'createReadStream' is defined but never used

Check failure on line 4 in packages/artifact/src/internal/upload/zip.ts

View workflow job for this annotation

GitHub Actions / Build (windows-latest) 

'createReadStream' is defined but never used
import {UploadZipSpecification} from './upload-zip-specification'
import {getUploadChunkSize} from '../shared/config'

Expand Down Expand Up @@ -44,7 +44,7 @@
for (const file of uploadSpecification) {
if (file.sourcePath !== null) {
// Add a normal file to the zip
zip.append(createReadStream(file.sourcePath), {
zip.file(file.sourcePath, {
name: file.destinationPath
})
} else {
Expand Down
Loading