Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Pin version for tcl/tk and pkg-config #10971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarathrajsrinivasan
Copy link
Contributor

Description

  1. Pin version for tcl/tk to 8.
  2. Pin version for pkg-config to 0.29.2. Check and migrate to "pkgconf" if basic functionality is identical.

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@@ -72,7 +72,6 @@
"p7zip",
"packer",
"perl",
"pkg-config",
"swiftformat",
"tcl-tk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will be changed if we just use a package with a version here instead of another condition? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could update as "tcl-tk@8" directly here as well..just thought this would be neat and similar format to earlier pinned versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants