WIP migrate from c8/mocha to native node test runner #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected], npm/[email protected] |
chris48s
commented
Nov 18, 2024
| @@ -89,6 +90,7 @@ describe("PackageJsonNodeVersion", function () { | |||
| describe("getAction", function () { | |||
| afterEach(function () { | |||
| delete process.env["INPUT_INTEGRATION"]; | |||
| process.exitCode = undefined; | |||
There was a problem hiding this comment.
The reason for doing this is:
setFailed() sets process.exitCode
https://github.com/actions/toolkit/blob/bb2278e5cfbb40afc20890c415e9ffa836631cd5/packages/core/src/core.ts#L220-L224
Unlike Mocha, this causes Node's test runner to consider the test failed, even if it happened inside a assert.throws()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an interesting experiment: Can I replace c8/mocha with the native node test runner.
Some learnings:
.test.jsfiles from the coverage reports. This can be done with--test-coverage-excludebut this is not available until node 22.action.js, even though it is not under test. Even using--test-coverage-includeI was not able to do this.--test-reporter junitProbably not going to immediately migrate but it is good to check in on what this looks like.