Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const specifier for not changed strings. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobbad
Copy link

@tobbad tobbad commented Apr 23, 2016

I try to integrate uGui into micropython when I saw these small issues. In my opinion a string which is not modified in the receiving function should be declared as const. This is as well needed by the function which call the ugui function where I receive a const char *. Further there are some small fixes which satisfy a picky gcc. I have a little bit problem with this latin-1 encoded file in eclipse and some fixes below show, that others had it, too. Why not just use the regular ASCII set?

@jmoyerman
Copy link

Good stuff.

Const modifiers are always useful wherever you can put them.

I've messaged Achim before, he hasnt abandoned the project, just University. Ill merge this into my branch when I get infront of a PC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants