Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support protocol 2.0 and php 8.3 #191

Merged
merged 11 commits into from
Mar 21, 2024
Merged

Support protocol 2.0 and php 8.3 #191

merged 11 commits into from
Mar 21, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 15, 2024 •
edited
Loading

Fixed #190
Fixed #187
Fixed #192

@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 15, 2024 12:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 15, 2024 12:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 18, 2024 11:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 20, 2024 11:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 20, 2024 12:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 20, 2024 12:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 20, 2024 16:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/191/features March 20, 2024 16:47 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review March 21, 2024 13:13
ttypic
ttypic reviewed Mar 21, 2024
View reviewed changes
src/Defaults.php Outdated Show resolved Hide resolved
@sacOO7 sacOO7 requested a review from umair-ably March 21, 2024 13:35
ttypic
ttypic approved these changes Mar 21, 2024
View reviewed changes
Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Mar 21, 2024

LGTM

Thanks for the approval 👍

@sacOO7 sacOO7 merged commit 563a84f into main Mar 21, 2024
15 checks passed
@sacOO7 sacOO7 deleted the feature/upgrade-protocol-2.0 branch March 21, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@owenpearson owenpearson Awaiting requested review from owenpearson

@umair-ably umair-ably Awaiting requested review from umair-ably

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix idempotent rest publishing [REST] update to protocol 2.0 Add support for PHP 8.3
2 participants
@sacOO7 @ttypic