[WIP] Add unsubscribeAll methods to unsubscribing all listeners at once
#1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAll` Also deprecates the ability to call `.unsubscribe()` methods without any valid parameters.
VeskeR
changed the title
unsubscribeAll methods to unsubscribing all listeners at onceunsubscribeAll methods to unsubscribing all listeners at once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is driven by
unsubscribeAllused in Chat SDK and related DR https://ably.atlassian.net/wiki/spaces/CHA/pages/3141992466/CHADR-035+Unsubscribing+All+Listeners+at+Once.Deprecates the ability to call
.unsubscribe()methods without any valid parameters.TODO:
test for unsubscribeAll
update spec with unsubscribeAll
add type safety to complain when called
.unsubscribe(undefined)