Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Deprecate truck parameter in route_v8 #85

Conversation

maciej-wichowski
Copy link
Contributor

According to the documentation, truck attribute is deprecated in Routing requests if favour of vehicle attribute. This commit deprecates the truckattribute.
It can be still used, however a warning will appear in the console and the request will be sent with vehicle attribute. Values accepted in both attributes are the same in the API.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (a9a623f) to head (00af7e7).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   92.99%   93.01%   +0.01%     
==========================================
  Files          26       26              
  Lines        1755     1760       +5     
==========================================
+ Hits         1632     1637       +5     
  Misses        123      123              
Flag Coverage Δ
unittests 93.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maciej-wichowski maciej-wichowski force-pushed the fix-route_v8_truck_attribute_depecated branch from 64791c7 to 00af7e7 Compare October 18, 2024 22:02
@abdullahselek abdullahselek self-assigned this Oct 19, 2024
Copy link
Owner

@abdullahselek abdullahselek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for catching that deprecation!

@abdullahselek abdullahselek merged commit 90d43d0 into abdullahselek:master Oct 19, 2024
21 of 22 checks passed
@maciej-wichowski maciej-wichowski deleted the fix-route_v8_truck_attribute_depecated branch October 21, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants