Add handling of forbidden errors from here api response #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for raising this, it's simple as you said but if you have time a clean implementation would be better. And also a new test case 🙂 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 93.24% 93.25%
=======================================
Files 26 26
Lines 1733 1735 +2
=======================================
+ Hits 1616 1618 +2
Misses 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like with the new update from here, there's a new "Forbidden" response if you have not set up you account with billing.
Added in a quick block to handle that error.
Decided on duplicating the code into an
elifovererror in ["forbidden", "unauth"]Main choice was to keep things a bit simpler and not nest too much logic in one line...
Happy to jump in and give the whole block a clean if that will help get this in :)