Skip to content

Commit

Permalink
fixed the docs and removed errant TODO. (TraceMachina#1085)
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcusSorealheis authored Jul 6, 2024
1 parent 54a9345 commit f777126
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions nativelink-config/src/cas_server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,13 @@ pub struct ByteStreamConfig {
/// According to <https://github.com/grpc/grpc.github.io/issues/371>
/// 16KiB - 64KiB is optimal.
///
/// TODO(marcussorealheis) in the config tests, include a defined max_bytes_per_stream.
///
/// Defaults: 64KiB
#[serde(default, deserialize_with = "convert_data_size_with_shellexpand")]
pub max_bytes_per_stream: usize,

/// Used when the config specifies a maximum number of bytes to decode on each grpc stream chunk.
/// Maximum number of bytes to decode on each grpc stream chunk.
/// Defaults: 4 MiB
#[serde(default, deserialize_with = "convert_data_size_with_shellexpand")]
pub max_decoding_message_size: usize,

Expand Down

0 comments on commit f777126

Please sign in to comment.