Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More interface translations #4137

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

More interface translations #4137

wants to merge 9 commits into from

Conversation

IndeIrae
Copy link
Contributor

@IndeIrae IndeIrae commented Oct 5, 2020

Adds:

  • Startup commander menu;
  • Command panel (commands, states, menu names);
  • Com-upgrade menu;
    +
  • End-graph (doesn't fetch non-eng);
  • Defence ranges menu (doesn't fetch non-eng);
  • Color menu on top-left panel (desc broken, pretty sure its in stable lol);
  • Reclaim and overdrive lil' energy and metal signs.
    To translations.

Also adds a suprise tool, that will help us later failsafe for fails to load-in translation files (replaces it with eng version, i think? Made by Anarchid).
Works now*.

Upd to new ui names, designations and etc according to latest changes. Rus file borked for now, most of translations were placeholders and were due a re-do anyway.
@GoogleFrog
Copy link
Contributor

That isn't unexpected but it is possible to search the code. Iirc this overrides the state names unless you're in the alternate mode.

As for whether to munch on them, idk, I don't do translations. Personally they get in the way of development and probably break the UI alignment in ways that I'll never see. But high coverage is probably good to have overall.

@IndeIrae
Copy link
Contributor Author

IndeIrae commented Oct 12, 2020

My thinking is that it's fruitless anyway to translate every little bit because at some point in-game you'll need arcane knowledge of english to progress (also just the sheer amount of stuff flowing in and out). That being said, i believe it would be nice to have basic player ui and at least part of default widgets available for translation (maybe lobby and campaign as well some time later if this pans out). Atm we have like... unit names, i guess? Even this will double interface lines.

@GoogleFrog
Copy link
Contributor

I don't like spreading translation and command tooltips throughout files like cmd_newton_firezone.lua. I'd revert the changes to cmd_newton_firezone.lua and simply add a tooltip override in the integral menu config.

@Anarchid
Copy link
Member

Sounds like something that could be done iteratively.

@Anarchid
Copy link
Member

To clarify: by doing iteratively here i mean i would prefer this merged as-is so that translations for these strings start accruing on transifex.

Refactoring the way the integral menu does all strings can happen a bit later. I expect to be able to do a bit more than a cursory glance in November.

@IndeIrae
Copy link
Contributor Author

Yea, i mentioned it in a previous pull but just to be clear: i can't do code at all.
I can do the busy work with all the WG calls, thats about it, so i'm stuck running around to ppl for help.

Added defense ranges, team color menu, end graph, energy and metal letters from overdrive window and reclaim info to translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants