Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mergify): remove deprecated speculative_checks option #9033

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

gustavovalverde
Copy link
Member

Motivation

While using Mergify's configuration checker, this issue was not raised, but it's now showing in some PR's summaries, as in https://github.com/ZcashFoundation/zebra/pull/9026/checks?check_run_id=33066692861

Specifications & References

Solution

  • Use the new root level option max_parallel_checks

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

While using Mergify's configuration checker, this issue was not raised, but it's now showing in some PR's summaries, as in https://github.com/ZcashFoundation/zebra/pull/9026/checks?check_run_id=33066692861
@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑 labels Nov 18, 2024
@gustavovalverde gustavovalverde self-assigned this Nov 18, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner November 18, 2024 11:00
@gustavovalverde gustavovalverde requested review from upbqdn and removed request for a team November 18, 2024 11:00
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge C-deprecated labels Nov 18, 2024
@gustavovalverde gustavovalverde merged commit 2a6e184 into main Nov 18, 2024
97 checks passed
@gustavovalverde gustavovalverde deleted the fix-mergify branch November 18, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-deprecated C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants