Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute scores for probes #33

Merged
merged 4 commits into from
May 4, 2024
Merged

Compute scores for probes #33

merged 4 commits into from
May 4, 2024

Conversation

imenelydiaker
Copy link
Collaborator

@imenelydiaker imenelydiaker commented May 4, 2024

  • Compute F1, recall and precision scores per layer and per concept.
  • Compute same scores per pixel_values.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imenelydiaker - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Hard-coded secret detected: HF_TOKEN should not be exposed in the code. (link)
Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🔴 Security: 1 blocking issue
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

scripts/constants.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
scripts/analysis/probes_analysis.py Outdated Show resolved Hide resolved
@Xmaster6y Xmaster6y merged commit 4ceaac5 into main May 4, 2024
1 check passed
@Xmaster6y Xmaster6y deleted the sanity-check-probes branch May 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants