Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Ensure consistent image block rendering between editor and frontend #67089

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

himanshupathak95
Copy link

Fixes: #67088

What?

Changes the CSS property of image blocks from max-width: 100% to width: 100% to ensure consistent rendering between editor and frontend.

Why?

  • Low-resolution images were displaying inconsistently between editor and frontend
  • This broke the WYSIWYG (What You See Is What You Get) experience
  • Users were getting confused by different image sizes in editor vs published view
  • Prior implementation with max-width allowed images to shrink below their container width

How?

  • Modified the CSS for .wp-block-image img selector
  • Changed max-width: 100% to width: 100%
  • Maintained height: auto for proper aspect ratio
  • Preserved existing animation and visibility state styles

Testing Instructions

  1. In the site editor, Add an image block
  2. Upload or select a low-resolution image (e.g., 300x200px)
  3. Observe the image size in editor
  4. Save and preview/publish the post
  5. Compare the image dimensions between editor and frontend

Screencast

Before fix:

img-block-width-fix-before.mov

After fix:

img-block-width-fix-after.mov

…ntend

The image block previously showed inconsistent behavior when displaying
low-resolution images. Images appeared correctly sized in the editor but
rendered horizontally smaller on the frontend, breaking visual parity. This change ensures that low-resolution images maintain consisten dimensions across both the Gutenberg editor and frontend view, improving
the WYSIWYG experience for users.
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <[email protected]>
Co-authored-by: Infinite-Null <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @himanshupathak95! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency of image block with low resolution image in frontend and editor
1 participant