DFW: reset zombie state on unmount #67076
Open
+11
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
draganescu,
youknowriad,
talldan,
jeryj and
stokesman
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -41 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 18, 2024
| // by default. | ||
| useEffect( | ||
| () => () => { | ||
| onToggle( true ); |
There was a problem hiding this comment.
It doesn't feel like the right place to call this for me. It should be the responsibility of the parent component IMO (unless the state is moved to within this component)
There was a problem hiding this comment.
The thing is that the parent component never sets this state, it appears it's only used inside this one. But the parent component needs to be aware of it to hide the document bar. Tbh, I think the local state is bad here, it should probably be done differently. I just didn't feel like refactoring it.
There was a problem hiding this comment.
I changed the whole thing to use CSS.
youknowriad
approved these changes
Nov 18, 2024
ellatrix
commented
Nov 18, 2024
| if ( blockSelectionStart ) { | ||
| onToggle( false ); | ||
| } | ||
| }, [ blockSelectionStart, onToggle ] ); |
There was a problem hiding this comment.
Oh, I think we'll want to keep this. It should uncollapse whenever you change selection I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Whenever exiting Distraction Free Writing, the document toolbar is gone.
Why?
It should re-appear. This also seems important because Bluesky is using DFW.
How?
Just use CSS to hide the document toolbar.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast