Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border support to calender #67007

Conversation

NidhiDhandhukiya74
Copy link

What?

Add border block support to the Calendar block.
Part of #43247

Why?

Calendar block is missing border support.

How?

Adds the border block support in block.json.

Testing Instructions

Go to Global Styles Settings. ( Under Appearance > Editor > Styles > Edit styles > Blocks )
Make sure that Calendar block's border is Configurable via Global Styles.
Edit Template/ Single Post Template & Add Calendar block and Apply the border Styles.
Verify that Calendar block styles take precedence over global Styles.
Verify that Calendar block borders display correctly in both the Editor and Frontend.

Testing Instructions for Keyboard

Screenshots or screencast

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: NidhiDhandhukiya74 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@skorasaurus skorasaurus added the [Block] Calendar Affects the Calendar Block label Nov 15, 2024
@akasunil akasunil added [Type] Enhancement A suggestion for improvement. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Nov 18, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NidhiDhandhukiya74! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@akasunil
Copy link
Member

Hi @NidhiDhandhukiya74 Looks like calendar block had already open PR #64345 for border support. I'm closing this in favor of #64345

@akasunil akasunil closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants