-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextControl: Deprecate 36px default size #66745
TextControl: Deprecate 36px default size #66745
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍
In addition to this though, there are a lot of code snippets in Markdown files and Storybook stories across the repo that use TextControl, and all of them need the prop. Otherwise the devs referring to those snippets would be copy pasting deprecated code. (I added some clarification in the original issue's procedure checklist.)
Hi @mirka I have updated the markdown files and stories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Part of #65751
What?
Deprecate the 36px default size in TextControl.
Testing Instructions