New image viewer #6035
Open
New image viewer #6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # package.json
cadeyrn
reviewed
Oct 23, 2024
…ancyBox groups automatically
…the default config.
TimWolla
reviewed
Oct 23, 2024
There was a problem hiding this comment.
The new library should be added to
WCF/.github/workflows/javascript.yml
Line 39 in 35e8777
|
Note: This is blocked while we’re discussing the licensing terms with the vendor. |
dtdesign
requested changes
Nov 11, 2024
There was a problem hiding this comment.
You forgot to update files/js/.buildOrder, it still includes WCF.ImageViewer.
Also, are we somehow able to dynamically group images that exist in the same message? Currently the image viewer spans all images on one page which also means that, for example, attachments from multiple posts are mixed together.
Co-authored-by: Alexander Ebert <[email protected]>
…ey are not grouped together with those from the content
# Conflicts: # package-lock.json # package.json
dtdesign
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5966
TODO
wcf.imageViewer.*.jsImageVieweris no longer useddata-captionand nottitleis usedshared_imageViewerinstead ofimageViewerWCF.Combined.min.jsandWCF.Combined.tiny.min.js