Skip to content

Commit

Permalink
refactor: add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
WofWca committed Aug 7, 2024
1 parent 948a540 commit 28912f7
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,9 @@ export default class Controller {
// Also keep in mind that `createMediaElementSource` and `captureStream` are not 100% interchangeable.
// For example, for `el.volume` doesn't affect the volume for `captureStream()`.
// TODO fix: fall-back to `createMediaElementSource` if these are not supported?
//
// TODO perf: destroy the stream and AudioContext when it's not necessary,
// i.e. when the popup is closed.
type HTMLMediaElementWithMaybeMissingFields = HTMLMediaElement & {
captureStream?: () => MediaStream,
mozCaptureStream?: () => MediaStream,
Expand Down

0 comments on commit 28912f7

Please sign in to comment.