-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added contents for testing of wasmedge apps #177
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adithya Krishna <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: The pull request titled "feat: added contents for testing of wasmedge apps" includes several individual summaries of the key changes made. After considering all the individual summaries, it is clear that there are a few potential issues and errors that need attention. The first potential problem is the deletion of the Next, there is a typo in the code snippet in the Furthermore, the new content added for testing wasmedge apps lacks context, which makes it difficult to assess the correctness and completeness of the changes. In addition to these potential issues, there are a few important findings worth mentioning. The changes include updates to the lists of tools and frameworks used for testing wasmedge applications. However, the commit message should provide more context and explanation about why the lists were updated. Furthermore, a new link for testing wasmedge has been added, and the file Overall, the changes appear to add new testing documentation for wasmedge apps. However, there are potential issues and errors that need clarification, and additional context and explanation is required for a thorough assessment of the changes. DetailsCommit 5f89bd23e2da1d4013bdba33f2ae935e73029f23Key changes:
Potential problems:
Overall, the changes appear to add new testing documentation for wasmedge apps. However, the reasons for deleting the Commit 490b64a51ffdb1cf9b13abdc5f20369899f6f0acKey changes:
Potential problems:
Commit d5b9ad3596a3f2cdd637e949d997f98e6d1dba73Key changes:
Potential problems:
Commit 72404a1323888a80093355dbde0be5c22327ea1fKey changes in the patch:
Potential problems:
Overall, the changes seem to be adding Chinese documentation for testing WasmEdge applications. However, more information and context is needed to fully understand the purpose and impact of these changes. Commit 7cbe458793407f9dc6f83d84524c57f9aa7cf4f1Key Changes:
Potential Problems:
Suggested Improvements:
Commit 2c4cef1fb69e69e527a4a4d7443c26a353a5a165Key changes:
Potential problems:
|
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
"position": 4, | ||
"link": { | ||
"type": "generated-index", | ||
"description": "We will learn how to test WasmEdge applications" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the contributor guide, I think we should learn how to test WasmEdge itself, not the WasmEdge applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alabulei1 As discussed, how abt if we move this so that users can know how to test wasmedge apps?
If so, could you please suggest a subheading where I can move this to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Wasm apps is the question that the Wasm community wants to solve. I don't think we can solve the problem.
Signed-off-by: Adithya Krishna <[email protected]>
"position": 4, | ||
"link": { | ||
"type": "generated-index", | ||
"description": "We will learn how to test WasmEdge applications" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Wasm apps is the question that the Wasm community wants to solve. I don't think we can solve the problem.
Signed-off-by: Adithya Krishna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this is called WasmEdge applications?
If you are developing the WasmEdge internal, tools, and plugins, then it should be WasmEdge testing.
"position": 4, | ||
"link": { | ||
"type": "generated-index", | ||
"description": "We will learn how to test WasmEdge applications" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. The testing should be test WasmEdge itself
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
This PR adds the written content for testing of WasmEdge applications