Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Repair duplication and multiple completions #101

Merged
merged 17 commits into from
Aug 1, 2023

Conversation

RHammond2
Copy link
Contributor

This PR addresses three inter-related issues:

  1. Operating levels > 100% due to the subassembly reset process' improper use of multiple if statements in place of a longer if/elif block
  2. Repairs being completed more than once due to an improper recursive loop in the crew transfer mechanisms during shift delays
  3. Repairs having equipment dispatched more than once due to inconsistent handling of pending, processing, and completed repair statuses

See the changelog for complete details.

@RHammond2 RHammond2 added the bug Something isn't working label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #101 (580d3eb) into develop (503abf4) will increase coverage by 0.12%.
The diff coverage is 45.88%.

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    54.57%   54.69%   +0.12%     
===========================================
  Files           21       21              
  Lines         3500     3556      +56     
  Branches       709      720      +11     
===========================================
+ Hits          1910     1945      +35     
- Misses        1473     1491      +18     
- Partials       117      120       +3     
Files Changed Coverage Δ
wombat/core/port.py 15.55% <9.37%> (-1.54%) ⬇️
wombat/core/service_equipment.py 62.41% <61.90%> (+2.08%) ⬆️
wombat/core/repair_management.py 67.65% <70.00%> (-0.72%) ⬇️
wombat/core/data_classes.py 85.71% <100.00%> (+0.05%) ⬆️

@RHammond2 RHammond2 merged commit 766474a into develop Aug 1, 2023
7 of 8 checks passed
@RHammond2 RHammond2 deleted the bug_fix/multiple_repairs branch August 1, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant