Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the format of the integrity block from
[magic, version, signatures]
to[magic, version, ib_attributes, signatures]
, whereib_attributes
is a map with a single attribute calledwebBundleId
; this field's purpose is to simplify key rotation while having a guarantee that the ID of the web bundle is always stable regardless of the signing keys specified.The default behavior of the signing tool stays the same, i.e. the following invocation
wbn-sign --input {bundle} -k {key} -o {output}
will continue generating the usual
v1
bundles.With
v2
, on the contrary, it's now possible to have the bundle signed by multiple signatures in parallel and explicitly call out the exactweb-bundle-id
:wbn-sign --version v2 --input {bundle} -k {key1} {key2} {key3} -o {output} --web-bundle-id {id}
Chrome supports both
v1
&v2
bundles as of M128.