Feature RTL support in locale #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h level rtl class on the html tag
…ML, which has been fixed as well
|
Thanks, this looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the RTL Support the ticket I have created #2669
Could you please check it carefully, as I don't have slightest idea about the impacts, but it's working fine on my local project for translations of StateOfJS ;)
Devographics/state-of-js-graphql-results-api#50
After checking the code, I had come to the conclusion that without this, the RTL support was not possible at all.
This is just the beginning and give the developer the opportunity by usage of RTL class in HTML to do custom CSS if needed ;)