Skip to content

Commit

Permalink
Merge pull request #34 from VowpalWabbit/fix_notebook
Browse files Browse the repository at this point in the history
fix news recommendation notebook
  • Loading branch information
olgavrou authored Nov 16, 2023
2 parents f854f96 + b4a7fe8 commit e5f91fe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion notebooks/news_recommendation.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
" chosen_article = picked[\"article\"]\n",
" user = event.based_on[\"user\"]\n",
" time_of_day = event.based_on[\"time_of_day\"]\n",
" score = self.get_score(user[0], time_of_day[0], chosen_article)\n",
" score = self.get_score(user, time_of_day, chosen_article)\n",
" return score"
]
},
Expand Down
3 changes: 1 addition & 2 deletions src/learn_to_pick/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,7 @@ def run(self, *args, **kwargs) -> Dict[str, Any]:
)
except Exception as e:
logger.info(
f"The selection scorer was not able to score, \
and the chain was not able to adjust to this response, error: {e}"
f"The selection scorer was not able to score, and the chain was not able to adjust to this response, error: {e}"
)

event = self._call_after_scoring_before_learning(score=score, event=event)
Expand Down

0 comments on commit e5f91fe

Please sign in to comment.