Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix applications response types #956

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

s-lukashenka-micoworks
Copy link
Contributor

  • Applications API response type is missing a privateKey field.
  • Applications API does not require all the three webhook URLs to be passed during creation but the type does not allow to omit any.

Description

Motivation and Context

This PR helps resolve failing type checks. The API itself works fine and has the mentioned field in its response.
Related to #955.

Testing Details

Not sure if I did things right but I ran the test suite on the PR branch.
Please, let me know if some other tests or changes are needed.

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pardel pardel requested a review from manchuck September 5, 2024 08:28
* The private key for the application.
*
* @remarks
* Store this value securely.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to be:

This will only be present when the application is created, or when you cycle the public key when doing an update

Copy link
Contributor Author

@s-lukashenka-micoworks s-lukashenka-micoworks Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manchuck updated the doc 🙇

@manchuck manchuck merged commit 7eda9db into Vonage:3.x Sep 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants