fix(voice): ncco encoding (#906)

Vonage · Jan 23, 2024 · 9f2cfc8 · 9f2cfc8
1 parent aec47d6
commit 9f2cfc8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/packages/voice/__tests__/__dataSets__/create.ts b/packages/voice/__tests__/__dataSets__/create.ts
@@ -36,6 +36,16 @@ export default [
             {
               action: NCCOActions.TALK,
               text: "I'll always dial the K for you",
+              bargeIn: false,
+            },
+            {
+              payload: {
+                room_name: 'my-room',
+                id: 'CON-00000000-0000-0000-0000-000000000000',
+              },
+              eventUrl: ['https://example.com/event'],
+              eventMethod: 'POST',
+              action: 'notify',
             },
           ],
           random_from_number: false,
@@ -80,6 +90,16 @@ export default [
           {
             action: NCCOActions.TALK,
             text: "I'll always dial the K for you",
+            bargeIn: false,
+          },
+          {
+            payload: {
+              room_name: 'my-room',
+              id: 'CON-00000000-0000-0000-0000-000000000000',
+            },
+            eventUrl: ['https://example.com/event'],
+            eventMethod: 'POST',
+            action: 'notify',
           },
         ],
         randomFromNumber: false,

diff --git a/packages/voice/lib/voice.ts b/packages/voice/lib/voice.ts
@@ -1,5 +1,4 @@
 import { AuthenticationType, Client, FileClient } from '@vonage/server-client';
-import { NCCOActions } from './enums';
 import {
   GetCallDetailsParameters,
   CallPageResponse,
@@ -12,6 +11,7 @@ import {
   Action,
   TalkAction,
   OutboundCall,
+  CallWithNCCO,
 } from './types';
 
 import { ResponseTypes } from '@vonage/vetch';
@@ -237,9 +237,14 @@ export class Voice extends Client {
    * ```
    */
   async createOutboundCall(call: OutboundCall): Promise<CallResult> {
+    const callRequest = Client.transformers.snakeCaseObjectKeys(call, true);
+    if ((call as CallWithNCCO).ncco) {
+      callRequest.ncco = (call as CallWithNCCO).ncco;
+    }
+
     const resp = await this.sendPostRequest<CreateCallResponse>(
       `${this.config.apiHost}/v1/calls`,
-      Client.transformers.snakeCaseObjectKeys(call, true),
+      callRequest,
     );
     const result = Client.transformers.camelCaseObjectKeys(
       resp.data,