-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update as well the subscription-models based on the new commonalities - models.
I did it already for DeviceLocation
I used the general template for it:
https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml
At the end a request should look like that: {
"protocol": "HTTP",
"sink": "https://notificationSendServer12.supertelco.com",
"types": [
"org.camaraproject.connected-network-type-subscriptions.v0.network-type-changed"
],
"config": {
"subscriptionDetail": {
"device": {
"phoneNumber": "+12345678912"
}
},
"initialEvent": true,
"subscriptionMaxEvents": 10,
"subscriptionExpireTime": "2024-03-22T05:40:58.469Z"
}
} |
Review comments added
@maxl2287 HI, I have updated all the review comments and created file as per the new given camara standard template https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the file to fit plural
-naming:
device-network-type-subscriptions.yaml
And please update the file name. |
…network-type-subscriptions.yaml correcting the file name and making it plural
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Provides Connected network type subscription API/enpoints
Which issue(s) this PR fixes:
(camaraproject#143)
Fixes #
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.