Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-point-service): resetCache should clear stale data #494

Conversation

schiavig
Copy link
Collaborator

@schiavig schiavig commented Feb 9, 2024

resetCache should clear stale data

fix #492

What: resetCache doesn't remove stale data so, it happens that for removed contents it still provide old data

Why:

How: removing stale data on promise chain

Checklist:

  • Has Breaking changes N/A
  • Documentation
  • Tests
  • Ready to be merged
  • Added username to all-contributors list

resetCache doesn't remove stale data so, it happens that for removed contents it still provide old
data. Implemented the clear of stale data on promise chain

fix ViacomInc#492
@schiavig schiavig force-pushed the 492-resetcache-should-clear-stale-data branch from 94eb2b6 to d3db273 Compare February 9, 2024 16:09
@schiavig schiavig added the 📦data-point-service DataPointService Package label Feb 9, 2024
@schiavig schiavig assigned acatl and unassigned acatl Feb 9, 2024
@schiavig schiavig requested a review from acatl February 9, 2024 16:53
@schiavig schiavig merged commit 8f2e60f into ViacomInc:data-point-service-4x Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦data-point-service DataPointService Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants