-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New reged #14
Open
csalzberger
wants to merge
28
commits into
VerifiableRobotics:development
Choose a base branch
from
csalzberger:new_reged
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New reged #14
csalzberger
wants to merge
28
commits into
VerifiableRobotics:development
from
csalzberger:new_reged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odified in RegionFileInterface and Region, adding and adjusting methods for parsing data from the new file format. Distinct colors and names added to regions produced by regionEditor.
…ck after editing some region. Also made editing regions done using region object rather than index.
…le, dragable, and deletable.
…UI but have not yet added functionality.
…dary on menu. Fixed some label positioning issues with boundary.
…tandalone listener in python for it.
Conflicts: src/lib/regions.py src/regionEditor.py src/specEditor.py
… format and convert them to the old way of storing, while still being able to save and open the old file format for decomposed regions. Updated regionEditor.py so that it can handle the new file format as well (using json for region storage). Note that calibration does not automatically happen yet in regions.py.
…or keeping aspect ratio during calibration, or allowing skewing.
…acencies at every step.
…nality for importing background images. Made images scalable with dimension/length button. Added grid to map. Added display of lines and other things on mouse movement. Changed redraw to draw to bitmap, then to canvas, which reduces flashing, especially for redrawing Vicon.
…hanged methods so that they can act as toggles. Separated CalibrationFrame wxGlade file from regionEditor.
…tions of regions.
… other little bugs.
…though). Also added keyboard shortcuts for more menu and button items in regionEditor, and noted them in the menus and tooltips.
…nup of the folder. ViconMarkerBroadcaster added for streaming vicon markers. wxglade files added for new regionEditor and calibration GUIs.
TODO: put bounds on zooming, otherwise crashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that may need to be done to make transition smoother for people:
-Being able to read old region file formats and import them seamlessly.
-Re-adding transparency to the region drawing in Region Editor. There is some issue with doing this when the regions are drawn to a bitmap and the bitmap is drawn to the window.
-Test for the text to speech module, pyttsx, and avoid importing if it is not available. Also disable the “Speech” option in audio feedback.
-Check which operating system is being used and make appropriate substitution for module winsound.