Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove simple jquery instances #903

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Remove simple jquery instances #903

merged 4 commits into from
Mar 7, 2024

Conversation

jernestmyers
Copy link
Contributor

@jernestmyers jernestmyers commented Mar 1, 2024 •
edited
Loading

Works toward tasks in #899, specifically:

  • TabbableContainer: used in Popup, AnswerFilterSelector, RecordFilter, OverThumbnails; should be simple enough to replace jquery code w/ vanilla JS and/or react refs
  • AnswerFilterSelector: used in one trivial line
  • RemoteContent and VerticalScrollHelper: neither seem to be in use and can be deleted

@jernestmyers jernestmyers marked this pull request as ready for review March 7, 2024 20:25
dmfalke
dmfalke approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jernestmyers jernestmyers merged commit d0dc038 into main Mar 7, 2024
1 check passed
@jernestmyers jernestmyers deleted the debt/remove-simple-jquery-cases branch March 7, 2024 20:57
@jernestmyers jernestmyers mentioned this pull request Mar 7, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmfalke dmfalke dmfalke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jernestmyers @dmfalke