Map - commented code for costing allowing other types of variable in the TimeSlider #1075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #761
Allowing the other continuous variables doesn't look too tricky.
It's looking like string ordinals (for example with 'YYYY-MM' values) may require a separate
TimeSlider
component for the following reasonsonChange
callback ofBrush
will return a list of selected values (indomain.values
) instead of the range (domain.x0
todomain.x1
)Brush
) - at least as a Phase 1.