-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variable reference #16
Conversation
Thanks for pointing out option 3. The GitHub landing page has improved over the last year and is now easier to read for non-coders. Personally, I'm never using the website. |
Would be fine with option 3. To fix it, i think you now have to give the token permission to write:
https://github.com/JamesIves/github-pages-deploy-action It is also possible to store the website as artifact (instead of using the gh-pages branch): Happy to update the workflow if we don't go for option 3 |
Yes, I am totally fine with removing the website! |
I removed the relevant stuff, should be good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kequach for updating the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this workflow meant to sort and update the README.md if it is not properly sorted? If so, then I think we should add a commit action to commit the result
Co-authored-by: Jelle Treep <[email protected]>
@jelletreep good point, I think the commit/push was implicit with the deployment of the page. Haven't thought about that |
Thanks! |
Variable reference apparently changed from GITHUB_TOKEN to TOKEN.