Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEN2-82] fix borrow functionality #227

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[GEN2-82] fix borrow functionality #227

wants to merge 2 commits into from

Conversation

jdrco
Copy link
Contributor

@jdrco jdrco commented Jul 28, 2023

Fix Borrow functionality.

  • Now have modal/popups
  • Now actually adds the borrow transaction in transactions collection

@jdrco jdrco requested a review from royayush1 July 28, 2023 01:36
@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for glittery-kulfi-b3068d ready!

Name Link
🔨 Latest commit 7be21f4
🔍 Latest deploy log https://app.netlify.com/sites/glittery-kulfi-b3068d/deploys/64c31bb56b0176000874fe0d
😎 Deploy Preview https://deploy-preview-227--glittery-kulfi-b3068d.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jdrco jdrco changed the title Feat/gen2 82 borrow functionality [GEN2-82] fix borrow functionality Jul 28, 2023
@notion-workspace
Copy link

FEAT: CUST: Fix Borrow Functionality

ArmaanKatyal
ArmaanKatyal requested changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@ArmaanKatyal ArmaanKatyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please delete all the firebase logic that access the database directly from frontend. We have created backend for that specific reason. For ex: app/src/features/api.tsx. I can still see code in the frontend making direct call to database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmaanKatyal ArmaanKatyal ArmaanKatyal requested changes

@royayush1 royayush1 Awaiting requested review from royayush1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrco @ArmaanKatyal