Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASC-73 #8

Merged
merged 12 commits into from
Feb 26, 2024
Merged

ASC-73 #8

merged 12 commits into from
Feb 26, 2024

Conversation

khanheric2003
Copy link
Member

@khanheric2003 khanheric2003 commented Feb 19, 2024

PQ: Implemented component MediaUploadZone and MediaUploadZoneTestRoute

Note: needs feedback on sizing the fonts, padding, and margin between elements inside the drop box

TODO: Adjust sizing of fonts, margin, padding again.

Copy link

github-actions bot commented Feb 19, 2024

Visit the preview URL for this PR (updated for commit 381639d):

https://alzheimercalgary-v2--pr8-asc-73-twhcph74.web.app

(expires Mon, 04 Mar 2024 20:00:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 49842b2747b50197f445c596a105e7df038b0757

Copy link
Collaborator

@TienDucHo TienDucHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read my comments? Thanks

src/components/MediaUploadZone.tsx Outdated Show resolved Hide resolved
src/components/MediaUploadZone.tsx Show resolved Hide resolved
Copy link
Member Author

@khanheric2003 khanheric2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

src/components/MediaUploadZone.tsx Outdated Show resolved Hide resolved
@TienDucHo TienDucHo merged commit 499c8ce into main Feb 26, 2024
2 checks passed
@TienDucHo TienDucHo deleted the ASC-73 branch February 26, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants