Button fixes #40
Merged
Button fixes #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 75c8f87): https://alzheimercalgary-v2--pr40-button-fixes-6fb8pfr2.web.app (expires Fri, 08 Nov 2024 04:00:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 49842b2747b50197f445c596a105e7df038b0757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ key fixes
square and round buttons no longer one-size fits all. pass the shape prop with either "round" or "square" for those button shapes and they will adhere to the size prop that you provide.
added a severity = "dangerPrimary" option for the off change we need a filled button that is also red.
fixed the weird off-centre issue
fixed all existing buttons
updated ButtonTestRoute.tsx file for documentation