Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bandage: add prop to hide close button #34

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

cottiera
Copy link
Collaborator

@cottiera cottiera commented Oct 9, 2024

Adds a prop that lets a parent hide the close icon in the top right corner of the modal and a higher level control prop called 'closeable' that disables all methods of closing the modal.

@cottiera cottiera self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit 5a1ec96):

https://alzheimercalgary-v2--pr34-optional-close-butto-kno5u1t1.web.app

(expires Wed, 16 Oct 2024 19:34:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 49842b2747b50197f445c596a105e7df038b0757

Copy link
Collaborator

@TienDucHo TienDucHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TienDucHo TienDucHo merged commit 1347f36 into main Oct 22, 2024
2 checks passed
@TienDucHo TienDucHo deleted the optional-close-button branch October 22, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants