Implement sort dropdown list #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement [ASC-67]
Add the sort dropdown list test route
Add the feature which close the dropdown when the user click outside of the component.
This seems to be the only case for my laptop since it won't work without these new lines in this file.
Added both route path to test features like navigation bar and dropdown list
|
Visit the preview URL for this PR (updated for commit 0be9b40): https://alzheimercalgary-v2--pr3-asc-67-feature-imple-lu73rzcq.web.app (expires Sat, 17 Feb 2024 00:16:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 49842b2747b50197f445c596a105e7df038b0757 |
|
Good results! But your implementation can be improved by using and element for the Dropdown List and the Dropdown Item. Can you rewrite them again using those tags? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] Implement sort dropdown list
This component is built with two files: SortDropdownList.tsx and DropdownItem.tsx. Beside that there is a test route named SortDropdownListTestRoute.tsx.