Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NetworkAnimator parameters writebuffer is limited [backport] #3124

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

NoelStephensUnity
Copy link
Collaborator

This is a backport of #3108.

This PR resolves the issue of exceeding the legacy parameter limitations defined within NetworkAnimator. Now, NetworkAnimator calculates how much space it needs to allocate to handle parameter serialization based on the Animator's defined parameters.

Changelog

  • Fixed: Issue where NetworkAnimator would statically allocate write buffer space for Animator parameters that could cause a write error if the number of parameters exceeded the space allocated.

Testing and Documentation

  • No tests were added.
  • No documentation changes or additions were necessary.

Pre-calculate the required parameter write size needed as opposed to using the legacy constant value.
adding changelog entry
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner November 14, 2024 23:58
Adding PR number to changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant