Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: raise provisioned concurrency to avoid queueing #487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alanhwu
Copy link
Collaborator

@alanhwu alanhwu commented Oct 23, 2024

There are cases where order webhooks are sent significantly later than their creations.
This causes potential fillers to receive them late and exclusive fillers may miss their exclusivity period, causing a fade.
Orders are sent 1 at a time, and from the logs it seems that lambda instances can have orders queued, which means we may not have enough of them. This problem is more pronounced when a previous execution of a lambda "hangs" from a ECONN or similar error that makes the notification execution 5+ seconds rather than a quick sub-second operation.

Copy link
Collaborator

@codyborn codyborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants