fix: 712 ordering for Priority Orders #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
approved these changes
Jul 17, 2024
ConjunctiveNormalForm
approved these changes
Jul 17, 2024
zhongeric
added a commit
that referenced
this pull request
Jul 25, 2024
* initial commit - priority fee reactor, lib, and structs * Implement reactor, add tests and library tests * forge fmt * Add validation tests * nit: comment * change to MPS * forge fmt * remove unchecked loop * add comment * replace mps with pips * rename back to mps * fix comment and test * add comment * Set maxAmount to original input amount to fix token permissions error * forge fmt * comments: cache value in lib * Add explicit edge case priority fee lib tests * forge fmt * add tests * add baseFee assert * forge fmt * feat: add cosigner logic and minPriorityFee (#254) * Add cosigner logic * Add invalid cosigner and cosignature tests * Add minPriorityFee * remove openAuctionStartBlock * add revert test for filling before cosigner and before auction start block * remove unused error * Only validate cosignature if before auctionStartBlock * add custom revert for txGasprice < block base fee * add revert test for txgasprice * remove view modifier * only call updateCosignerData func if before auctionStartBlock * move getPriorityFee into separate func * fix compiler warnings for tests --------- Co-authored-by: ConjunctiveNormalForm <[email protected]> * fix: cosigner verification edge cases and other fixes (#255) * move cosigner verification logic into validate * Add cosignerlib * nit: comments * Add tests to CosignerLib * flip and forge fmt * Fix 712 ordering (#258) * chore: add better gas coverage for priority orders * fix gas snaps * feat: revert quickly if order is already filled (#259) * revert quickly if invalid nonce * update gas snaps * add tests for invalid nonces * Change revert to OrderAlreadyFilled * forge fmt * rm console2 --------- Co-authored-by: ConjunctiveNormalForm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using SDK integration test and it passes.
PERMIT2_ORDER_TYPEis used to transfer tokens via permit2,ORDER_TYPEis used to hash the order.