wrap input scale in unchecked block (#264)

Uniswap · Aug 2, 2024 · d4b7da8 · d4b7da8
1 parent 22339cd
commit d4b7da8
Show file tree

Hide file tree

Showing 13 changed files with 19 additions and 17 deletions.
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-BaseExecuteSingleWithFee.snap b/.forge-snapshots/Base-PriorityOrderReactor-BaseExecuteSingleWithFee.snap
@@ -1 +1 @@
-184811
+184760
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatch.snap b/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatch.snap
@@ -1 +1 @@
-202966
+202864
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatchMultipleOutputs.snap b/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatchMultipleOutputs.snap
@@ -1 +1 @@
-212779
+212677
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatchMultipleOutputsDifferentTokens.snap b/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatchMultipleOutputsDifferentTokens.snap
@@ -1 +1 @@
-266488
+266386
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatchNativeOutput.snap b/.forge-snapshots/Base-PriorityOrderReactor-ExecuteBatchNativeOutput.snap
@@ -1 +1 @@
-196492
+196390
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-ExecuteSingle.snap b/.forge-snapshots/Base-PriorityOrderReactor-ExecuteSingle.snap
@@ -1 +1 @@
-151202
+151151
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-ExecuteSingleNativeOutput.snap b/.forge-snapshots/Base-PriorityOrderReactor-ExecuteSingleNativeOutput.snap
@@ -1 +1 @@
-136764
+136713
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-ExecuteSingleValidation.snap b/.forge-snapshots/Base-PriorityOrderReactor-ExecuteSingleValidation.snap
@@ -1 +1 @@
-160512
+160461
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-InputPriorityFee.snap b/.forge-snapshots/Base-PriorityOrderReactor-InputPriorityFee.snap
@@ -1 +1 @@
-153387
+153336
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-OutputPriorityFee.snap b/.forge-snapshots/Base-PriorityOrderReactor-OutputPriorityFee.snap
@@ -1 +1 @@
-153196
+153145
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-OutputPriorityFeeAndBaselinePriorityFee.snap b/.forge-snapshots/Base-PriorityOrderReactor-OutputPriorityFeeAndBaselinePriorityFee.snap
@@ -1 +1 @@
-153190
+153139
diff --git a/.forge-snapshots/Base-PriorityOrderReactor-OverrideAuctionTargetBlock.snap b/.forge-snapshots/Base-PriorityOrderReactor-OverrideAuctionTargetBlock.snap
@@ -1 +1 @@
-130640
+130589
diff --git a/src/lib/PriorityFeeLib.sol b/src/lib/PriorityFeeLib.sol
@@ -24,11 +24,13 @@ library PriorityFeeLib {
         if (scalingFactor >= MPS) {
             return InputToken({token: input.token, amount: 0, maxAmount: input.amount});
         }
-        return InputToken({
-            token: input.token,
-            amount: input.amount.mulDivDown((MPS - scalingFactor), MPS),
-            maxAmount: input.amount
-        });
+        unchecked {
+            return InputToken({
+                token: input.token,
+                amount: input.amount.mulDivDown((MPS - scalingFactor), MPS),
+                maxAmount: input.amount
+            });
+        }
     }
 
     /// @notice returns a scaled output using the current priority fee and mpsPerPriorityFeeWei