Miscellaneous Cleanups #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
had a problem deploying
to
CodeCov
GitHub Actions
Failure
dopplershift
force-pushed
the
cleanup
branch
from
cf6cd1e
to
32e3071
Compare
dcamron
requested changes
Nov 12, 2024
This hasn't been touched in 9 years and is out of date.
For examples, switch to proper now(timezone.utc). In tests, timezone does not actually matter in those tests, so just use the simpler now().
This fixes a code analysis error in PyCharm.
Use a context manager to only filter at the time we set the units attribute, which minimizes impact. It also helps silence warnings when running the test suite.
Set xfail_strict to true and also make warnings trigger errors.
Cleans up a warning with little change in the support window.
dopplershift
force-pushed
the
cleanup
branch
from
32e3071
to
fa4f169
Compare
|
In addition to addressing the review comments, I went ahead and pushed a commit that enables Sphinx nitpicky mode and cleans up all of the issues that identified. |
Also clean up a bunch of issues with references found by nitpicky mode.
dopplershift
force-pushed
the
cleanup
branch
from
bf94426
to
74b01ef
Compare
dcamron
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
TODO.mdutcnow().unitsonDataFramesChecklist