-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix: Populate Dataset access_urls #736
base: main
Are you sure you want to change the base?
Conversation
|
Taking another stab to get the tests passing in the CI. My opening comment in this PR mentioned 38 test failing on my machine when following the test instructions. Only three tests failed in the CI so there's clearly a difference in these testing implementations. In any event trying to get those failed tests passing so this can be reviewed. |
@dopplershift Can I rerun the CI here or is that beyond my permissions? |
Just kicked them off, thanks for the poke. |
@dopplershift Well this was embarrassing. Once more time would be appreciated. |
Thank you @dopplershift. Looks like flake8 and tests are passing. There are some other checks not passing (Docs Build) but I don't think I changed anything here. Please let me know if that is something I should fix! |
@dopplershift Looks like there are some lower-level build failures (numpy and cartopy) that are happening in the CI. Have we seen these before? Seems unrelated to the changes made in this PR. Re-poking just incase. |
Description Of Changes
This is an incremental PR that will need some attention to testing and additional input. Intended to get the ball rolling.
Minor change to
catalog.py
which permits populatingDataset.access_urls
in situations whereservice_name
is not inall_service_dict
.See #734 and #715.
38 tests were failing prior to my change. 41 tests failed afterward. Common themes across the three new failures:
OPeNDAP is chosen as a first (and sometimes only)
access_url
rather than HTTPServer. Oddly I cannot replicate these assertion errors in ipython.Checklist