Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Python version update, contributors, code of conduct #271

Merged
merged 6 commits into from
Jul 17, 2019

Conversation

zbruick
Copy link
Contributor

@zbruick zbruick commented Jul 5, 2019

Addresses 7/8 issues in #270.

@zbruick zbruick mentioned this pull request Jul 5, 2019
7 tasks
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things. Looks good otherwise. Thanks for taking care of it!

.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@zbruick
Copy link
Contributor Author

zbruick commented Jul 15, 2019

Updated based on the review and rebased on master.

@zbruick
Copy link
Contributor Author

zbruick commented Jul 15, 2019

Travis is failing on the same issue as #269. @lesserwhirls mentioned to me that Unidata will be adopting a broader Code of Conduct to be implemented soon(?), so we may not want to add that right now for sake of clarity on this issue. I can take that commit out if desired.

@lesserwhirls
Copy link
Collaborator

@ddirks is working with UCAR on some of the language used in their Code of Conduct for contributors, but we think that will be resolved in a few days. I have a PR over on Unidata/.github (Unidata/.github#1) that will turn on a default Code of Conduct for the Unidata organization that follows the UCAR Code of Conduct. The UCAR Code of Conduct for contributors is based on the Contributor Covenant version 1.4, so the on in this PR (and on metpy) is very similar, but not identical.

@dopplershift
Copy link
Member

Let's take out the code of conduct here and just rely on the organization one, since that makes the most sense.

@zbruick
Copy link
Contributor Author

zbruick commented Jul 17, 2019

The code of conduct has been dropped from this PR. Travis will probably error out on IGRA, but the rest of the tests should be green.

@dopplershift
Copy link
Member

Test failures on Travis due to IGRA2 crapping out docs. Merging...

@dopplershift dopplershift merged commit ba4ba42 into Unidata:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants