-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Python version update, contributors, code of conduct #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things. Looks good otherwise. Thanks for taking care of it!
Updated based on the review and rebased on master. |
Travis is failing on the same issue as #269. @lesserwhirls mentioned to me that Unidata will be adopting a broader Code of Conduct to be implemented soon(?), so we may not want to add that right now for sake of clarity on this issue. I can take that commit out if desired. |
@ddirks is working with UCAR on some of the language used in their Code of Conduct for contributors, but we think that will be resolved in a few days. I have a PR over on Unidata/.github (Unidata/.github#1) that will turn on a default Code of Conduct for the Unidata organization that follows the UCAR Code of Conduct. The UCAR Code of Conduct for contributors is based on the Contributor Covenant version 1.4, so the on in this PR (and on metpy) is very similar, but not identical. |
Let's take out the code of conduct here and just rely on the organization one, since that makes the most sense. |
The code of conduct has been dropped from this PR. Travis will probably error out on IGRA, but the rest of the tests should be green. |
Test failures on Travis due to IGRA2 crapping out docs. Merging... |
Addresses 7/8 issues in #270.