This repository has been archived by the owner on Apr 9, 2020. It is now read-only.
brownie function! #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user a "brownie" or wen used without a username it gives your amount of brownie points
ericm
reviewed
Mar 3, 2020
| if (System.getenv(variable) == null) { | ||
| println("$variable not set\nExiting") | ||
| exitProcess(1) | ||
| } | ||
| } | ||
| var fileObject = File("brownieLeaderboard.txt") |
ArthanJans
suggested changes
Mar 3, 2020
| if (System.getenv(variable) == null) { | ||
| println("$variable not set\nExiting") | ||
| exitProcess(1) | ||
| } | ||
| } | ||
| var fileObject = File("brownieLeaderboard.txt") |
There was a problem hiding this comment.
I would use a dB instead of a file, simply a pair of user ID to amount of brownie points should be fine
| // gonna use a file cause i dont know if im allowed to use a databse | ||
| var leaderboardFile = File("brownieLeaderboard.txt") | ||
| var yes = leaderboardFile.readLines() | ||
| if (receiver != null && author.id != receiver.id) { |
There was a problem hiding this comment.
I would add a check to see that the author has not given someone else a brownie already today, could get quite spammy as it is now. This could be checked by simply storing author ID to the timestamp of the last time they gave a brownie point.
|
|
||
| // gonna use a file cause i dont know if im allowed to use a databse | ||
| var leaderboardFile = File("brownieLeaderboard.txt") | ||
| var yes = leaderboardFile.readLines() |
There was a problem hiding this comment.
Better variable names PLEASE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its jsut a command where people can view how many brownie points they have gotten and also be able to give brownie points
the code is very bad
ver bad
i insist
very bad
also the only restriction i have is that you cant give yourself a brownie point