-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/118_footer_strip #141
Conversation
- Add footer field to default INI config - ReadmeClass: define curation_dict
I believe this fixes the issue with the excess footer. A few things: At a later point when we decide to update the metadata, we should make sure the formatting is identically to what is intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find the two test deposits in stage that you referred to here.
However, I reviewed the changes and they all look fine. I think for the sake of completing this before winterbreak we can close this issue since we'll be implementing further deposit checks later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature won't be included in release/v0.17.0
. The footer seem to vary with deposit.
For 12935162, the footer anchor appears to be: <br></p><br><br><hr><br><i>
# Conflicts: # ldcoolp/curation/inspection/readme/__init__.py
- Use horizontal line indicator - Use str.endswith() and string indexing to strip
- Update ReadmeClass with Qualtrics call
I have successfully ran a README.txt construction using Some notable issues with handling of footer in Summary: UPDATE: Adding a strip for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Closes #118
See #203 (some changes here for interactive disabling for faster script run)