Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant target frameworks #267

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Remove redundant target frameworks #267

merged 1 commit into from
Nov 14, 2024

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 14, 2024

The removed targets should already be covered by existing netstandard targets.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (edc95c6) to head (2a41195).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          46       46           
  Lines        1100     1100           
  Branches       85       85           
=======================================
  Hits         1045     1045           
  Misses         35       35           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz merged commit 99bd5fb into master Nov 14, 2024
7 checks passed
@Tyrrrz Tyrrrz deleted the remove-old-frameworks branch November 14, 2024 02:56
@hawkeye116477
Copy link

Is support for 4.6.2 dropped?

From MS site:

CONSIDER adding a target for net462 when you're offering a netstandard2.0 target.

Using .NET Standard 2.0 from .NET Framework has some issues that were addressed in .NET Framework 4.7.2. You can improve the experience for developers that are still on .NET Framework 4.6.2 - 4.7.1 by offering them a binary that's built for .NET Framework 4.6.2.

hawkeye116477 added a commit to hawkeye116477/CliWrap that referenced this pull request Nov 18, 2024
@Tyrrrz
Copy link
Owner Author

Tyrrrz commented Nov 19, 2024

@hawkeye116477 have you tried using it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants