Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper cleanup for deployed process signaler #259

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Proper cleanup for deployed process signaler #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97770a4
WindowsSignaler generates its own temp filename instead of using GetT…
xpherism Sep 19, 2024
4f298a6
Update CliWrap/Utils/WindowsSignaler.cs
Tyrrrz Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CliWrap/Utils/WindowsSignaler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ internal partial class WindowsSignaler
public static WindowsSignaler Deploy()
{
// Signaler executable is embedded inside this library as a resource
var filePath = Path.ChangeExtension(Path.GetTempFileName(), "exe");
var filePath = Path.Combine(Path.GetTempPath(), $"CliWrap.Signaler.{Guid.NewGuid()}.exe");
Assembly.GetExecutingAssembly().ExtractManifestResource("CliWrap.Signaler.exe", filePath);

return new WindowsSignaler(filePath);
Expand Down